Re: [whatwg/encoding] Editorial: separate `TextDecoderStream` constructor to two algos (PR #364)

@noamr commented on this pull request.



> @@ -1851,23 +1851,31 @@ constructor steps are:
 
  <li><p>If <var>encoding</var> is failure or <a>replacement</a>, then <a>throw</a> a {{RangeError}}.
 
- <li><p>Set <a>this</a>'s <a for=TextDecoderCommon>encoding</a> to <var>encoding</var>.
+ <li><p>Let <var>errorMode</var> be <code>fatal</code> if <var>options</var>["{{TextDecoderOptions/fatal}}"] is true; otherwise <code>replacement</code>.

Done

>  
- <li><p>Set <a>this</a>'s <a for=TextDecoderCommon>decoder</a> to a new instance of <a>this</a>'s
- <a for=TextDecoderCommon>encoding</a>'s <a for=/>decoder</a>, and set <a>this</a>'s
- <a for=TextDecoderCommon>I/O queue</a> to a new <a for=/>I/O queue</a>.
+<div algorithm>
+<p>To <dfn export>set up a text decoder stream</dfn> <var>stream</var>, given an optional [=/encoding=] <var>encoding</var> (default <a>UTF-8</a>),

Done

>  
- <li><p>Set <a>this</a>'s <a for=TextDecoderCommon>decoder</a> to a new instance of <a>this</a>'s
- <a for=TextDecoderCommon>encoding</a>'s <a for=/>decoder</a>, and set <a>this</a>'s
- <a for=TextDecoderCommon>I/O queue</a> to a new <a for=/>I/O queue</a>.
+<div algorithm>
+<p>To <dfn export>set up a text decoder stream</dfn> <var>stream</var>, given an optional [=/encoding=] <var>encoding</var> (default <a>UTF-8</a>),
+an optional <a for=/>error mode</a> <var>errorMode</var> (default <code>replacement</code>), and an optional boolean <var>ignoreBOM</var> (default false), run these steps:
+
+<ol>

Done

> @@ -1877,7 +1885,11 @@ constructor steps are:
  <a for="TransformStream/set up"><var ignore>flushAlgorithm</var></a> set to
  <var>flushAlgorithm</var>.
 
- <li><p>Set <a>this</a>'s <a for=GenericTransformStream>transform</a> to <var>transformStream</var>.
+ <li><p>Set <var>stream</var>'s <a for=TextDecoderCommon>decoder</a> to a new instance of <var>encoding</var>'s <a for=/>decoder</a>.
+
+ <li><p>Set <var>stream</var>'s <a for=TextDecoderCommon>I/O queue</a> to a new <a for=/>I/O queue</a>.

Done

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/364#discussion_r3272576808
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/encoding/pull/364/review/4326845341@github.com>