Re: [whatwg/dom] Define processing instruction attributes (PR #1454)

@annevk approved this pull request.

This looks good to me. You can consider WebKit supportive.

I'm still a bit on the fence about the `Name` production, but that can be changed in the future.

>  <div algorithm>
 <p>The <dfn attribute for=ProcessingInstruction>target</dfn> getter steps are to return
 <a>this</a>'s <a for=ProcessingInstruction>target</a>.
 </div>
 
+<div algorithm>
+<p>The <dfn method for=ProcessingInstruction><code>hasAttributes()</code></dfn> method steps are to
+return false if <a>this</a>'s <a for=ProcessingInstruction>attribute map</a>
+<a for=map>is empty</a>; otherwise true.
+</div>
+
+<div algorithm>
+<p>The <dfn method for=ProcessingInstruction><code>getAttributeNames()</code></dfn> method steps
+are to return the result of <a for=map>getting the keys</a> of <a>this</a>'s
+<a for=ProcessingInstruction>attribute map</a>.
+</div>
+
+<div algorithm>
+<p>The <dfn method for=ProcessingInstruction><code>getAttribute(<var>name</var>)</code></dfn> method
+steps are to return the result of <a lt="get a processing instruction attribute">getting a processing

No newlines inside phrasing-level elements. You also don't need `lt` here. "get" and "getting" will both work.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1454#pullrequestreview-4546510558
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1454/review/4546510558@github.com>