Re: [w3c/ServiceWorker] Editorial: queue a task in ServiceWorkerContainer.getRegistration (PR #1833)

@yoshisatoyanagisawa commented on this pull request.



> @@ -817,9 +817,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
         1. If the [=environment settings object/origin=] of |clientURL| is not |client|'s [=environment settings object/origin=], return a |promise| rejected with a "{{SecurityError}}" {{DOMException}}.
         1. Let |promise| be a new <a>promise</a>.
         1. Run the following substeps <a>in parallel</a>:
-            1. Let |registration| be the result of running <a>Match Service Worker Registration</a> given |storage key| and |clientURL|.
-            1. If |registration| is null, resolve |promise| with undefined and abort these steps.
-            1. Resolve |promise| with the result of [=getting the service worker registration object=] that represents |registration| in |promise|'s [=relevant settings object=].
+            1. [=Queue a task=] on |promise|'s [=relevant settings object=]'s [=responsible event loop=], using the [=DOM manipulation task source=], to run the following steps:
+                1. Let |registration| be the result of running <a>Match Service Worker Registration</a> given |storage key| and |clientURL|.

I suggest to move this step out of the [=Queue a task=] to allow the Match Service Worker Registration algorithm executed in parallel.

I assume it is the Match Service Worker Registration algorithm's responsibility to avoid corruption if there is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1833#pullrequestreview-4723670624
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1833/review/4723670624@github.com>