Re: [w3c/ServiceWorker] Editorial: Queue a task to resolve/reject promise or when fire an event. (PR #1755)

monica-ch left a comment (w3c/ServiceWorker#1755)



> Thanks for the updates, especially for addressing the CacheStorage race conditions! Sorry, I understand domenic suggested moving forward with item 1 here, but I feel the PR size is too large for me to approve with full confidence. Would it be possible to split the PR by feature? For example, having separate PRs for Cache API, NavigationPreloadManager, Clients API, and ServiceWorkerGlobalScope, and so on.

Make sense, split into 6 focused PRs off main, one per feature area. Please take a look when you get a chance!

getRegistration → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-serviceworkercontainer](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)
NavigationPreloadManager (4 methods) → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-navigationpreload](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)
skipWaiting → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-serviceworkerglobalscope](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)
Client / Clients API → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-clients-api](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)
Cache API → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-cache-api](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)
CacheStorage API (with the parallel queue) → [https://github.com/w3c/ServiceWorker/pull/new/queue-task-cachestorage-api](vscode-file://vscode-app/c:/Users/monicach/AppData/Local/Programs/Microsoft%20VS%20Code/974500e64f/resources/app/out/vs/code/electron-browser/workbench/workbench.html)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1755#issuecomment-4996721887
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1755/c4996721887@github.com>