[w3c/editing] Spec for InsertImage command is (no longer) 'correct'. (Issue #543)

Psychpsyo created an issue (w3c/editing#543)

While working on the Servo implementation of the InsertImage command, I noticed that Firefox has [changed their behavior](https://phabricator.services.mozilla.com/D225037) from something that follows the '[spec](https://w3c.github.io/editing/docs/execCommand/#the-insertimage-command)' to something that doesn't.
They also changed the web platform tests about this.
Specifically, their change is to split inline ancestors around the point that the image is inserted into.

My questions would be:
Is this the desired behavior? It unnecessarily adds a bunch of elements into the document.
Is there actually a web compat issue here or was this just done to match the WebKit implementation?
If this is here to stay, can we get a note in the 'spec' about this? (I know the spec is... in a dire state, but it's the best source there is, short of reverse-engineering everyone else, all of the time.)

Ladybird also currently just follows the 'spec' on this and will thus also fail that test: https://github.com/LadybirdBrowser/ladybird/blob/483865b7a636d32f1145464e8d6ab6aac8648c84/Libraries/LibWeb/Editing/Commands.cpp#L1341

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/editing/issues/543
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/editing/issues/543@github.com>