- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Wed, 15 Jul 2026 03:46:49 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1832/review/4703329281@github.com>
@yoshisatoyanagisawa commented on this pull request.
> @@ -3410,9 +3414,9 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Initialize |e|’s {{Event/cancelable}} attribute to true.
1. Initialize |e|’s {{FetchEvent/request}} attribute to |requestObject|.
1. Initialize |e|’s {{FetchEvent/preloadResponse}} to |preloadResponse|.
- 1. Initialize |e|'s {{FetchEvent/clientId}} attribute to |client|'s [=environment/id=].
- 1. If |request| is a <a>non-subresource request</a> and |request|'s [=request/destination=] is not {{RequestDestination/"report"}}, initialize |e|'s {{FetchEvent/resultingClientId}} attribute to |reservedClient|'s [=environment/id=], and to the empty string otherwise.
- 1. If |request| is a <a>navigation request</a>, initialize |e|'s {{FetchEvent/replacesClientId}} attribute to |request|'s [=request/replaces client id=], and to the empty string otherwise.
+ 1. If |client| is not null, initialize |e|'s {{FetchEvent/clientId}} attribute to |client|'s [=environment/id=].
+ 1. If |request| is a <a>non-subresource request</a>, |request|'s [=request/destination=] is not {{RequestDestination/"report"}}, and |reservedClient| is not null, initialize |e|'s {{FetchEvent/resultingClientId}} attribute to |reservedClient|'s [=environment/id=].
Is it relevant if the `resultingClientId` is an empty before this step?
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1832#pullrequestreview-4703329281
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/ServiceWorker/pull/1832/review/4703329281@github.com>
Received on Wednesday, 15 July 2026 10:46:53 UTC