Re: [w3c/ServiceWorker] Editorial: clarify FetchEvent clientId, resultingClientId, and replacesClientId initialization (PR #1832)

@yoshisatoyanagisawa commented on this pull request.



> @@ -1705,12 +1705,16 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
       <h4 id="fetch-event-clientid">{{FetchEvent/clientId|event.clientId}}</h4>
 
       <dfn attribute for="FetchEvent"><code>clientId</code></dfn> attribute *must* return the value it was initialized to. When an <a>event</a> is created the attribute *must* be initialized to the empty string.
+
+      Note: {{FetchEvent/clientId}} is |request|'s [=request/client=]'s [=environment/id=] for [=subresource requests=], and the empty string otherwise (including for [=non-subresource requests=] such as [=navigation requests=], or when |request|'s [=request/client=] is null). See {{FetchEvent/resultingClientId}} for the environment associated with the resulting document of a [=navigation request=].

Especially for Chrome, I did not know #1267 when I worked for PlzDedicatedWorker or so, and I intentionally plumbed clientId for navigation request.  I am not so convinced the clientId would be an empty string.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc;l=1554;drc=9437ad2580d9d89469a5f572fef982ab6b245115 (it guarantees resultingClientId will be an empty string for subresource, but clientId might be set for non-subresource cases)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1832#pullrequestreview-4694628527
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1832/review/4694628527@github.com>