Re: [whatwg/dom] Editorial: improve ensure pre-insert validity (PR #1484)

@noamr approved this pull request.

LGTM % nit

> + <li>
+  <p>If <var>parent</var> is not a <a for=/>document</a>:
+
+  <ol>
+   <li><p>If <var>node</var> is a <a>doctype</a>, then <a>throw</a> a
+   "{{HierarchyRequestError!!exception}}" {{DOMException}}.
+
+   <li><p>Return.
+  </ol>
+
+ <li><p>If <var>node</var> is a {{Text}} <a for=/>node</a>, then <a>throw</a> a
+ "{{HierarchyRequestError!!exception}}" {{DOMException}}.
+
+ <li><p>If <var>node</var> is a {{CharacterData}} <a for=/>node</a>, then return.
+
+ <li><p>Let <var>exclude</var> be <var>child</var> if <var>isReplace</var> is true; otherwise null.

Maybe call this <var>childToExclude</var> or <var>replacedChild</var>? it reads like a boolean otherwise

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1484#pullrequestreview-4653050333
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1484/review/4653050333@github.com>