Re: [whatwg/dom] Handle NodeIterator node removal during filtering (PR #1479)

@shannonbooth commented on this pull request.



>  <ol>
  <li><p>If <var>toBeRemovedNode</var> is not an <a for=tree>inclusive ancestor</a> of
- <var>nodeIterator</var>'s <a for=NodeIterator>reference</a>, or <var>toBeRemovedNode</var> is an
+ <var>nodePointer</var>'s <a for="node pointer">node</a>, or <var>toBeRemovedNode</var> is an

This is the same approach ladybird does to fix this scenario (factored slightly differently). I don't have any ideas for a less invasive approach.

Though the thing I noticed adjusting the implementation to match this exactly is if I understand correctly, I think nodePointer needs to be defined as a variable here from `nodeIterator` since it's not passed through in "given"

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1479#pullrequestreview-4619458602
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1479/review/4619458602@github.com>