- From: Anne van Kesteren <notifications@github.com>
- Date: Sat, 10 Jan 2026 01:55:57 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 10 January 2026 09:56:01 UTC
@annevk commented on this pull request.
> + <li><p>If <var>ipv4Piece</var> is null, then set <var>ipv4Piece</var> to <var>number</var>.
- <p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-code-point</a>
+ <li><p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-code-point</a>
<a>validation error</a>, return failure.
- <p>Otherwise, set <var>ipv4Piece</var> to <var>ipv4Piece</var> × 10 +
+ <li><p>Otherwise, set <var>ipv4Piece</var> to <var>ipv4Piece</var> × 10 +
<var>number</var>.
Looks like I just did this sloppily back in 2017: https://github.com/whatwg/url/commit/703fcd0b92053345582a36b2e4a642ab65df076e.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/894#discussion_r2678513931
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/url/pull/894/review/3646676209@github.com>
Received on Saturday, 10 January 2026 09:56:01 UTC