Re: [whatwg/url] Editorial: fix floating steps in IPv6 parser (PR #894)

@annevk commented on this pull request.



> +         <li><p>If <var>ipv4Piece</var> is null, then set <var>ipv4Piece</var> to <var>number</var>.
 
-          <p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-code-point</a>
+         <li><p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-code-point</a>
           <a>validation error</a>, return failure.
 
-          <p>Otherwise, set <var>ipv4Piece</var> to <var>ipv4Piece</var> &times; 10 +
+         <li><p>Otherwise, set <var>ipv4Piece</var> to <var>ipv4Piece</var> &times; 10 +
           <var>number</var>.

```suggestion
         <li><p>If <var>ipv4Piece</var> is null, then set <var>ipv4Piece</var> to <var>number</var>.

         <li><p>Otherwise, if <var>ipv4Piece</var> is 0, <a>IPv4-in-IPv6-invalid-code-point</a>
         <a>validation error</a>, return failure.

         <li><p>Otherwise, set <var>ipv4Piece</var> to <var>ipv4Piece</var> &times; 10 +
         <var>number</var>.
```
Looks great modulo indentation. I'm also going to look at blame as this is rather surprising.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/894#pullrequestreview-3646675561
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/894/review/3646675561@github.com>