Re: [whatwg/fullscreen] Add keyboard locking option (PR #232)

saschanaz left a comment (whatwg/fullscreen#232)

> Are you suggesting that sites looking to avoid things like tab switching have some enumeration of all browser shortcuts and just `.preventDefault()` on all of them? Isn't there at least some value in having that done for them?

(TIL Firefox and Chrome even allow that...)

But anyway that's what Safari is going to ship now - there's no "bypass" as this PR says, all it does is to prevent the escape key to not immediately escape the fullscreen mode. There's no even extra capture for shortcuts, it turns out that both Safari and Chrome already allow the page to capture extra browser shortcuts on fullscreen mode [that Firefox currently does not](https://bugzilla.mozilla.org/show_bug.cgi?id=1593883).

And I do think it may indeed be easier to just prevent-default those shortcuts in keyboard lock mode, but I'm not sure preventing all shortcuts is a great idea. Is Control+C a browser shortcut to prevent, for example? What is the definition of "browser shortcuts that we want to prevent" here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/232#issuecomment-3947531418
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/232/c3947531418@github.com>