Re: [whatwg/fullscreen] Add keyboard locking option (PR #232)

@saschanaz commented on this pull request.



> @@ -178,7 +184,14 @@ enum FullscreenNavigationUI {
   "hide"
 };
 
+enum FullscreenKeyboardLock {
+  "application",
+  "none",
+  "system"
+};
+

This is not what [STP is shipping now](https://searchfox.org/wubkat/rev/6e0c8e30ad2f1f8915549b6746fc43fa9c7f5a87/Source/WebCore/dom/FullscreenOptions.idl#37-39), are we going to update this or is WebKit going to change?

> +  <dt><dfn>System-level keyboard lock</dfn></dt>
+  <dd><p>Capture a wider range of keys, including those used for system-level navigation and
+  shortcuts (e.g., Alt+Tab), subject to user consent and user agent implementation.

I think STP is not doing this (I don't see anything non-browser short cut is being captured), do we need this in that case? Can environments like linux snap/flatpak support this? Sounds like we would surprisingly expose browser sandbox status if not.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/232#pullrequestreview-3739173936
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/232/review/3739173936@github.com>