Re: [w3c/manifest] Add `color_scheme_dark` member and themeable members (colors only) (PR #1207)

@marcoscaceres commented on this pull request.



> +          <p>
+            To <dfn>process the `color_scheme_dark` member</dfn>, given
+            [=ordered map=] |json:ordered map|, [=ordered map=]
+            |manifest:ordered map|, and [=URL=] |manifest URL:URL|:
+          </p>
+          <ol class="algorithm">
+            <li>If |json|["color_scheme_dark"] does not [=map/exist=], return.
+            </li>
+            <li>Let |colorScheme| be |json|["color_scheme_dark"].
+            </li>
+            <li>If |colorScheme| is not an [=ordered map=], return.
+            </li>
+            <li>Let |processedColorScheme:ordered map| be a new [=ordered
+            map=].
+            </li>
+            <li>[=Map/Set=] |manifest|["color_scheme_dark"] to

I was expecting to loop over the key value pairs of the |colorScheme|, and then switching on the key to process the value. But also, we should be clear what happens when there are repeated entries. I can't recall if first or last wins... but should follow what the other processing does.  

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1207#pullrequestreview-3806511742
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1207/review/3806511742@github.com>