Re: [w3c/manifest] Add `color_scheme_dark` member and themeable members (colors only) (PR #1207)

@marcoscaceres commented on this pull request.



> +          <p>
+            The [=manifest/color_scheme_dark=] member's [=ordered map=] accepts
+            [=themeable members=] as keys, and their values as the theme
+            overrides.
+          </p>
+          <p>
+            To <dfn>process the `color_scheme_dark` member</dfn>, given
+            [=ordered map=] |json:ordered map|, [=ordered map=]
+            |manifest:ordered map|, and [=URL=] |manifest URL:URL|:
+          </p>
+          <ol class="algorithm">
+            <li>If |json|["color_scheme_dark"] does not [=map/exist=], return.
+            </li>
+            <li>Let |colorScheme| be |json|["color_scheme_dark"].
+            </li>
+            <li>If |colorScheme| is not an [=ordered map=], return.

This should be an object, no? 

```suggestion
            <li>If |colorScheme| is not an [=object=], return.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1207#pullrequestreview-3806501832
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1207/review/3806501832@github.com>