Re: [w3c/ServiceWorker] Set request's initiator and destination to empty string in cache.addA… (PR #1822)

@wanderview requested changes on this pull request.



> @@ -2099,7 +2099,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
                 1. [=list/For each=] |fetchController| of |fetchControllers|, [=fetch controller/abort=] |fetchController|.
                 1. Return [=a promise rejected with=] a `TypeError`.
             1. If |r|'s [=request/client=]'s [=environment settings object/global object=] is a {{ServiceWorkerGlobalScope}} object, set |request|'s [=service-workers mode=] to "`none`".
-            1. Set |r|'s [=request/initiator=] to "`fetch`" and [=request/destination=] to "`subresource`".
+            1. Set |r|'s [=request/initiator=] and [=request/destination=] to the empty string.

Can we just remove the step.  I believe the defaults are empty string, right?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1822#pullrequestreview-4074990333
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1822/review/4074990333@github.com>