- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 25 Nov 2025 16:44:31 -0800
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 26 November 2025 00:44:35 UTC
@marcoscaceres commented on this pull request.
> </li>
- <li>Generate a new authentication secret, which is a sequence of octets as defined in
- [[RFC8291]]. Store the authentication secret in an internal slot on |subscription|. This
- key can be retrieved by calling the {{PushSubscription/getKey()}} method of the
- {{PushSubscription}} with an argument of {{PushEncryptionKeyName/"auth"}}.
+ <li>Set |subscription|'s [=authentication secret=] to the result of generating a new
+ authentication secret, which is a sequence of octets as defined in [[RFC8291]].
Same with this one... maybe @martinthomson can quickly check this one too for clarity?
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/414#pullrequestreview-3507625400
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/push-api/pull/414/review/3507625400@github.com>
Received on Wednesday, 26 November 2025 00:44:35 UTC