- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 25 Nov 2025 16:41:39 -0800
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 26 November 2025 00:41:43 UTC
@marcoscaceres commented on this pull request.
> @@ -757,16 +756,11 @@ <h2>
</li>
<li>Set |subscription|'s {{PushSubscription/options}} attribute to |options|.
</li>
- <li>Generate a new P-256 <a>ECDH</a> key pair [[ANSI-X9-62]]. Store the private key in an
- internal slot on |subscription|; this value MUST NOT be made available to applications.
- The public key is also stored in an internal slot and can be retrieved by calling the
- {{PushSubscription/getKey()}} method of the {{PushSubscription}} with an argument of
- {{PushEncryptionKeyName/"p256dh"}}.
+ <li>Set |subscription|'s [=P-256 ECDH key pair=] to the result of generating a new P-256
+ [=ECDH=] key pair [[ANSI-X9-62]].
If at all possible, I wonder if it's possible to link to the particular section of ANSI-X9-62 (or even if such a section exists?... I haven't checked).
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/414#pullrequestreview-3507613972
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/push-api/pull/414/review/3507613972@github.com>
Received on Wednesday, 26 November 2025 00:41:43 UTC