Re: [whatwg/dom] Set registry on null registry element on adopt instead of on insert (PR #1423)

@annevk commented on this pull request.



> @@ -2899,15 +2899,11 @@ before a <var>child</var>, with an optional <i>suppress observers flag</i>, run
      <a for=iteration>continue</a>.
 
      <li>
-      <p>If <var>inclusiveDescendant</var> is an <a for=/>element</a>:
+      <p>If <var>inclusiveDescendant</var> is an <a for=/>element</a> and
+      <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> is not null:

```suggestion
      <var>inclusiveDescendant</var>'s <a for=Element>custom element registry</a> is non-null:
```

>  
+      <ol>
+        <li><p>If <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>
+        is null, set <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>

then set

>  
+      <ol>
+        <li><p>If <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>
+        is null, set <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>

I think overall these two steps here and below would be better as follows, without using "is a global custom element registry" as that would do a redundant null check:

> If _node_'s custom element registry is null or _node_'s custom element registry's is scoped is false, then set _node_'s custom element registry to _document_'s effective global custom element registry.

>  
+      <ol>
+        <li><p>If <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>
+        is null, set <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>

Also, it appears you are changing the indentation here and below. This document uses single-space indentation.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1423#pullrequestreview-3481122943
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1423/review/3481122943@github.com>