- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 18 Nov 2025 22:31:33 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1424/review/3481020539@github.com>
@annevk approved this pull request.
Looks good modulo (my) nits.
> + <li><p>If <var>registry</var> is not null and <var>registry</var>'s
+ <a for=CustomElementRegistry>is scoped</a> is false and <var>registry</var> is not
+ <var>document</var>'s <a for=Document>custom element registry</a>, then <a>throw</a> a
+ "{{NotSupportedError!!exception}}" {{DOMException}}.
```suggestion
<li><p>If <var>registry</var> is non-null, <var>registry</var>'s
<a for=CustomElementRegistry>is scoped</a> is false, and <var>registry</var> is not
<var>document</var>'s <a for=Document>custom element registry</a>, then <a>throw</a> a
"{{NotSupportedError!!exception}}" {{DOMException}}.
```
> + <li><p>If <var>registry</var> is not null and <var>registry</var>'s
+ <a for=CustomElementRegistry>is scoped</a> is false and <var>registry</var> is not <a>this</a>'s
+ <a>node document</a>'s <a for=Document>custom element registry</a>, then <a>throw</a> a
+ "{{NotSupportedError!!exception}}" {{DOMException}}.
```suggestion
<li><p>If <var>registry</var> is non-null, <var>registry</var>'s
<a for=CustomElementRegistry>is scoped</a> is false, and <var>registry</var> is not <a>this</a>'s
<a>node document</a>'s <a for=Document>custom element registry</a>, then <a>throw</a> a
"{{NotSupportedError!!exception}}" {{DOMException}}.
```
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1424#pullrequestreview-3481020539
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/dom/pull/1424/review/3481020539@github.com>
Received on Wednesday, 19 November 2025 06:31:37 UTC