Re: [whatwg/fetch] Update HTTPFetch algorithm to support new SW Handle Fetch returns (PR #1832)

@annevk commented on this pull request.

Oh, I thought I had. Fortunately GitHub did preserve them. Sorry about that!

>  
-    <ol>
-     <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s
-     <a for="fetch timing info">final service worker start time</a> to
-     <var>serviceWorkerStartTime</var>.
+    <p>If <var>fetchResponse</var> is non-null, then:

```suggestion
    <p>If <var>fetchResponse</var> is non-null:
```

>  
-    <ol>
-     <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s
-     <a for="fetch timing info">final service worker start time</a> to
-     <var>serviceWorkerStartTime</var>.
+    <p>If <var>fetchResponse</var> is non-null, then:
+     <ol>
+     <li><p>If<var>fetchResponse</var> is <a for=/>response</a>, then:

```suggestion
     <li>
      <p>If<var>fetchResponse</var> is <a for=/>response</a>:
```

>  
-    <ol>
-     <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s
-     <a for="fetch timing info">final service worker start time</a> to
-     <var>serviceWorkerStartTime</var>.
+    <p>If <var>fetchResponse</var> is non-null, then:
+     <ol>
+     <li><p>If<var>fetchResponse</var> is <a for=/>response</a>, then:
+      <ol>
+       <li><p>Set <var>response</var> to <var>fetchResponse</var>.
+       <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s

Newline before the `<li>`s please.

> +     <li><p>If<var>fetchResponse</var> is <a for=/>service worker timing info</a>, then:
+      <ol>
+       <li><p>Set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s
+       <a for="fetch timing info">service worker timing info</a> to
+       <var>fetchResponse</var>.
+      </ol>

```suggestion
     <li><p>Otherwise, if <var>fetchResponse</var> is a <a for=/>service worker timing info</a>,
     then set <var>fetchParams</var>'s <a for="fetch params">timing info</a>'s
     <a for="fetch timing info">service worker timing info</a> to <var>fetchResponse</var>.
```

>      </ol>
-  </ol>
+   </ol>

This seems suspect given the `<li>` indentation below. We use single-space indentation.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1832#pullrequestreview-3441262483
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1832/review/3441262483@github.com>