Re: [w3c/ServiceWorker] Add new fields and getter steps for static routing resource timing (PR #1769)

@yoshisatoyanagisawa commented on this pull request.



> @@ -3278,6 +3300,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
 
                   1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps.
                   1. Associate |preloadResponseObject| with |navigationPreloadResponse|.
+                  1. If |timingInfo|'s [=service worker timing info/worker final router source=]is set to {{RouterSourceEnum/"network"}}, Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to {{RouterSourceEnum/"fetch-event"}}.

Can I ask why this line is needed?  If this is for SW static routing API, I thought the final router source is set in L3284.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1769#pullrequestreview-2856019935
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1769/review/2856019935@github.com>