- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Tue, 20 May 2025 19:02:50 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1769/review/2856014717@github.com>
@yoshisatoyanagisawa commented on this pull request. > @@ -2557,6 +2565,12 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ Note: Keep this definition in sync with [=fetch a classic worker-imported script=]. + A <dfn id="dfn-race-result">race result</dfn> is a [=tuple=] of a [=race result/race response=] and [=race result/used route=]. Please update existing [=race response=] to [=/race response=] to avoid confusion between [=/race response=] and [=race result/race response=]. Or, give a different name. There is bikeshed warning like: ``` LINE 1103:217: Multiple possible 'dfn' local refs for 'race response'. Randomly chose one of them; other instances might get a different random choice. [=race response=] LINE 3264:46: Multiple possible 'dfn' local refs for 'race response'. Randomly chose one of them; other instances might get a different random choice. [=race response=] LINE 3274:50: Multiple possible 'dfn' local refs for 'race response'. Randomly chose one of them; other instances might get a different random choice. [=race response=] LINE 3322:28: Multiple possible 'dfn' local refs for 'race response'. Randomly chose one of them; other instances might get a different random choice. [=race response=] ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1769#pullrequestreview-2856014717 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1769/review/2856014717@github.com>
Received on Wednesday, 21 May 2025 02:02:54 UTC