Re: [whatwg/fetch] Replace request's "window" with "traversable for user prompts" (PR #1823)

@noamr commented on this pull request.

All in all the direction looks good, one comment so far.

> @@ -4334,7 +4355,8 @@ the response. [[!HTTP-CACHING]]
    <li><p><var>request</var>'s <a for=request>mode</a> is "<code>same-origin</code>",
    "<code>cors</code>", or "<code>no-cors</code>"
 
-   <li><p><var>request</var>'s <a for=request>window</a> is an <a>environment settings object</a>
+   <li><p><var>request</var>'s <a for=request>client</a>'s

I believe `client` can be null, no? Perhaps there can be a helper algorithm to return request's document or window and performs the appropriate null checks?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1823#pullrequestreview-2835865754
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1823/review/2835865754@github.com>