Re: [whatwg/fetch] Replace request's "window" with "traversable for user prompts" (PR #1823)

@domenic commented on this pull request.



> @@ -4334,7 +4355,8 @@ the response. [[!HTTP-CACHING]]
    <li><p><var>request</var>'s <a for=request>mode</a> is "<code>same-origin</code>",
    "<code>cors</code>", or "<code>no-cors</code>"
 
-   <li><p><var>request</var>'s <a for=request>window</a> is an <a>environment settings object</a>
+   <li><p><var>request</var>'s <a for=request>client</a>'s

Yeah... not sure about the helper algorithm as I see people reaching for it a bit too eagerly, but maybe as a followup if we take a look at existing patterns in a bit more detail. Will fix the null dereference, and thanks for catching it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1823#discussion_r2086348043
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1823/review/2835952723@github.com>