Re: [whatwg/fetch] Add ServiceWorker Static Routing API support (PR #1737)

sisidovski left a comment (whatwg/fetch#1737)

@annevk Sorry to be late, I had a time to think about this.

Yes, we should respect the given request mode and filtered response, and we shouldn't look at [internal response](https://fetch.spec.whatwg.org/#concept-internal-response). As the ServiceWorker sides wants to tell if the response status is OK or not so that it can return the response from the cache if the network request failed, I think it makes sense filter out the case when the request mode is "no-cors" in the ServiceWorker side. Specifically, we'll add the condition "request mode is not no-cors" to the step 13.4 in [handle fetch](https://w3c.github.io/ServiceWorker/#handle-fetch). So "race-network-and-fetch-handler" doesn't work for "no-cors" any more, so we don't store the opaque filtered response to the [race response map](https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-race-response-map).

Does this address your concern?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1737#issuecomment-2693631455
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1737/c2693631455@github.com>