- From: Christian Liebel <notifications@github.com>
- Date: Thu, 31 Jul 2025 02:48:19 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 31 July 2025 09:48:23 UTC
christianliebel left a comment (w3ctag/design-reviews#1117) @SteveBeckerMSFT Thank you for your proposal. The potential performance improvements with the new `getAllRecords()` method look very promising. Adding direction options to the existing `getAll()` and `getAllKeys()` functions is great for consistency. Since detecting the availability of the new overloads by checking for the existence of the `getAllRecords()` function is rather unusual, we ask that you ensure the developer documentation clearly highlights this aspect. Apart from that, we agree that the compatibility risk is low since passing in dictionaries to `getAll()` and `getAllKeys()` was previously a programming error and could never have worked. Overall, we're closing this review as _satisfied_. -- Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/1117#issuecomment-3139262968 You are receiving this because you are subscribed to this thread. Message ID: <w3ctag/design-reviews/issues/1117/3139262968@github.com>
Received on Thursday, 31 July 2025 09:48:23 UTC