Re: [whatwg/storage] Add top-level site and cross site ancestry to storage key (PR #182)

@annevk commented on this pull request.



> @@ -207,10 +207,9 @@ anticipated that some APIs will be applicable to both <a>storage types</a> going
 <h3 id=storage-keys>Storage keys</h3>
 
 <p>A <dfn export>storage key</dfn> is a <a>tuple</a> consisting of an
-<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>). [[!HTML]]
-
-<p class=XXX>This is expected to change; see
-<a href="https://privacycg.github.io/storage-partitioning/">Client-Side Storage Partitioning</a>.
+<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>), a
+<dfn for="storage key">top-level site</dfn> (a <a for=/>site</a>), and a
+<dfn for="storage key">cross-site ancestry</dfn> (a boolean). [[!HTML]]

Let's rename this to "has cross-site ancestor" to align with what HTML ended up with.

> @@ -239,7 +238,18 @@ anticipated that some APIs will be applicable to both <a>storage types</a> going
  <a>environment settings object</a>; otherwise <var>environment</var>'s
  <a for=environment>creation URL</a>'s <a for=url>origin</a>.
 
- <li><p>Return a <a>tuple</a> consisting of <var>origin</var>.
+ <li><p>Let <var>topLevelOrigin</var> be <var>environment</var>'s
+ <a for=environment>top-level origin</a>.
+
+ <li><p>If <var>topLevelOrigin</var> is null, then set it to <var>origin</var>.
+
+ <li><p>Let <var>topLevelSite</var> be the result of <a>obtaining a site</a> given
+ <var>topLevelOrigin</var>.
+
+ <li><p>Let <var>crossSiteAncestry</var> be <var>environment</var>'s
+ <a for=environment>cross-site ancestry</a>.

@domenic @bvandersloot-mozilla now that has cross-site ancestor is no longer on environment, how is this going to work here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/182#pullrequestreview-3060626088
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/182/review/3060626088@github.com>