Re: [whatwg/storage] Add top-level site and cross site ancestry to storage key (PR #182)

@annevk approved this pull request.

This looks good to me modulo some minor nits. Thanks again for tackling it!

You can consider WebKit interested.

What's remaining:

1. Filing bugs against Gecko and WebKit and linking them from OP.
2. You can mark the MDN checkbox and say N/A.
3. Have you checked whether all the dependencies of this specification are holding the storage key correctly or are any doing something special with the origin field, for instance?
4. Is there a PR to rename the tests away from .tentative? (Assuming that there's nothing further that needs updating in the relevant specifications.)

cc @asutherland 

> @@ -16,6 +16,7 @@ urlPrefix: https://tc39.github.io/ecma262/; spec: ECMASCRIPT
 </pre>
 
 <pre class=link-defaults>
+spec:html; type:dfn; for:site; text:same site

Instead of this use `for=site` on the `<a>` element in question.

> @@ -207,10 +208,9 @@ anticipated that some APIs will be applicable to both <a>storage types</a> going
 <h3 id=storage-keys>Storage keys</h3>
 
 <p>A <dfn export>storage key</dfn> is a <a>tuple</a> consisting of an
-<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>). [[!HTML]]
-
-<p class=XXX>This is expected to change; see
-<a href="https://privacycg.github.io/storage-partitioning/">Client-Side Storage Partitioning</a>.
+<dfn for="storage key">origin</dfn> (an <a for=/>origin</a>), a
+<dfn for="storage key">top-level site</dfn> (a <a for=/>site</a>), and a
+<dfn for="storage key">cross-site ancestry</dfn> (a boolean). [[!HTML]]

Nice!

> + <li><p>If <var>A</var>'s <a for="storage key">cross-site ancestry</a> is not equal to
+ <var>B</var>'s <a for="storage key">cross-site ancestry</a>, then return false.

```suggestion
 <li><p>If <var>A</var>'s <a for="storage key">cross-site ancestry</a> is <var>B</var>'s
 <a for="storage key">cross-site ancestry</a>, then return false.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/182#pullrequestreview-2979311789
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/182/review/2979311789@github.com>