Re: [w3c/push-api] Add Declarative Web Push (PR #385)

@saschanaz commented on this pull request.

Mostly fine with a few changes. We explicitly did not cover the app badge part of this PR though.

> +                          [=push event result/notification shown=] and |appBadgeSet| to |result|'s
+                          [=push event result/app badge set=].
+                        </p>
+                      </li>
+                    </ol>
+                  </li>
+                  <li>
+                    <p>
+                      If |notificationShown| is false, then run the [=notification show steps=]
+                      given |notification|.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      If |appBadgeSet| is false, then <a href=
+                      "https://github.com/w3c/badging/issues/111">w3c/badging #111</a>...

(This part is incomplete)

> +                  Let |baseURL| be |registration|'s [=service worker registration/scope URL=].
+                </p>
+              </li>
+              <li>
+                <p>
+                  Let |origin| be |baseURL|'s [=url/origin=].
+                </p>
+              </li>
+              <li>
+                <p>
+                  Let |fallbackTimestamp| be [=current coarsened wall time=].
+                </p>
+              </li>
+              <li>
+                <p>
+                  Let |declarativeResult| be the result of running the [=/declarative push message

This happens after "If |registration| is not found, abort these steps." step above. Either #393 or this PR should fix that.

>                    </li>
-                  <li>Abort these steps.
+                  <li>
+                    <p>
+                      Let |notificationShown| be false.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      Let |appBadgeSet| be false.
+                    </p>
+                  </li>
+                  <li>
+                    <p>
+                      If |declarativeResult|'s [=declarative push message parser result/mutable=]
+                      is true:

Probably should check the existence of `registration` too?

>            <li>
             <p>
               <a>Fire a functional event</a> named "`push`" using <a>PushEvent</a> on
               |registration| with the following properties:
             </p>
             <dl>
               <dt>
-                `data`
+                {{PushEvent//data}}

```suggestion
                {{PushEvent/data}}
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/385#pullrequestreview-3055446433
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/385/review/3055446433@github.com>