- From: bvandersloot-mozilla <notifications@github.com>
- Date: Thu, 24 Jul 2025 11:38:30 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1775/review/3052786572@github.com>
@bvandersloot-mozilla commented on this pull request. > @@ -3065,6 +3065,11 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ :: Return |serviceWorker|'s [=service worker/script url=]. : The [=environment settings object/origin=] :: Return its registering [=/service worker client=]'s [=environment settings object/origin=]. + : The [=environment settings object/cross site ancestry=] + :: Return its registering [=/service worker client=]'s [=environment settings object/cross site ancestry=]. + <div class="note"> + Note: If service workers are not partitioned by the [=environment settings object/cross site ancestry=], clients must include logic to use the initial [=/http fetch=]'s [=/request=]'s [=request/client=]'s [=environment settings object/cross site ancestry=] when determining the "<code>SameSite</code>" mode. Is there a reword that would make more sense here, like this? Or are you suggesting we move this into the body here. ```suggestion Note: If service workers are not partitioned by the [=environment settings object/cross site ancestry=], clients can include logic to use the initial [=/http fetch=]'s [=/request=]'s [=request/client=]'s [=environment settings object/cross site ancestry=] when determining the "<code>SameSite</code>" mode. ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1775#discussion_r2229271114 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1775/review/3052786572@github.com>
Received on Thursday, 24 July 2025 18:38:34 UTC