- From: Westbrook Johnson <notifications@github.com>
- Date: Fri, 05 Dec 2025 09:10:25 -0800
- To: WICG/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 5 December 2025 17:10:29 UTC
@Westbrook commented on this pull request.
Thanks for correcting this. I think there was a little over eager find/replace there.
> @@ -294,8 +294,8 @@ This can improve the experience of using the components described in the [Backgr
this.shadowRoot_.innerHTML = `
<input id="input"
type="checkbox"
- ${checked == "true" ? "checked" : ""}
- aria-checked=${checked == "indeterminate" ? "mixed" : checked}>
+ ${this.checked == "true" ? "this.checked" : ""}
```suggestion
${this.checked == "true" ? "checked" : ""}
```
I think?
--
Reply to this email directly or view it on GitHub:
https://github.com/WICG/webcomponents/pull/1119#pullrequestreview-3545634088
You are receiving this because you are subscribed to this thread.
Message ID: <WICG/webcomponents/pull/1119/review/3545634088@github.com>
Received on Friday, 5 December 2025 17:10:29 UTC