Re: [w3c/permissions] Add an optional `topLevelOrigin` parameter to the `permissions.setPermission` command (PR #468)

miketaylr left a comment (w3c/permissions#468)

Hey thanks! A few questions/comments while I try to page this all back into my head.

Dumb question: why not just add an additional optional top-level origin argument into "set a permission" and plumb that in?

> The permission key generation algorithm has been updated to accept origin and top-level origin as direct inputs, instead of an Environment Settings Objects (ESO). This allows WebDriver to properly set a permission, since it doesn't necessarily have an ESO to pass.

I don't follow here - in https://pr-preview.s3.amazonaws.com/w3c/permissions/468/4f2ccb0...jalonthomas:4841693.html#automation you're calling the permission key generation algorithm with a [current settings object](https://html.spec.whatwg.org/multipage/webappapis.html#current-settings-object). So why do we need to modify the permission key generation algorithm? When does WebDriver have a CSO (which is a type of ESO) but not an ESO?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/468#issuecomment-3228030319
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/468/c3228030319@github.com>