- From: stelar7 <notifications@github.com>
- Date: Mon, 04 Aug 2025 15:09:45 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 4 August 2025 22:09:49 UTC
@stelar7 commented on this pull request. > @@ -5144,8 +5148,7 @@ To <dfn>abort a transaction</dfn> with the |transaction| to abort, and |error|, 1. Set |transaction|'s [=transaction/state=] to [=transaction/finished=]. -1. If |error| is not null, set |transaction|'s - [=transaction/error=] to |error|. +1. Set |transaction|'s [=transaction/error=] to |error|. Would it make more sense to abort early in that case? Aborting a transaction that is `finished` wouldnt do anything, since everything is comitted ``` 1. If |transaction|'s [=transaction/error=] is set, abort these steps ``` or ``` 1. If [=transaction/state=] is [=transaction/finished=], abort these steps ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/460#discussion_r2252671266 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/460/review/3085901144@github.com>
Received on Monday, 4 August 2025 22:09:49 UTC