Re: [w3c/ServiceWorker] The return value for update() is wrong in WebIDL (#1472)

asutherland left a comment (w3c/ServiceWorker#1472)

According to https://wpt.fyi/results/service-workers/service-worker/update-result.https.html?label=experimental&label=master&aligned all implementations are actually returning a ServiceWorkerRegistration which is [definitely what Gecko is doing despite what our .webidl file says](https://searchfox.org/mozilla-central/rev/e703d3fbd6da82cdda1256016a80abb1f245fedd/dom/serviceworkers/ServiceWorkerRegistration.cpp#318-329).

For clarity, [this is the check in update-result.https.html](https://searchfox.org/mozilla-central/rev/e703d3fbd6da82cdda1256016a80abb1f245fedd/testing/web-platform/tests/service-workers/service-worker/update-result.https.html#17-20):
```js
  let result = await reg.update();
  assert_true(result instanceof ServiceWorkerRegistration,
              'update() should resolve a ServiceWorkerRegistration');
}, 'ServiceWorkerRegistration.update() should resolve a registration object');
```

So I think we should update the WebIDL in the spec to reflect that a ServiceWorkerRegistration is returned and WebKit and Gecko should fix our in-tree .webidl files.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/issues/1472#issuecomment-2840854296
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/issues/1472/2840854296@github.com>