Re: [w3c/push-api] Allow firing pushsubscriptionchange on all permission changes (PR #400)

@saschanaz commented on this pull request.

>No, because this allows and does not mandate firing the event.

Why not mandate though if all browsers are going to do it?

We can still write WPT in that case though. I won't push this too strongly though because no browser can actually make any subscription from the upstream WPT CI. Firefox still can create subscriptions from our own WPT run, not sure Blink has the similar internal setup.

(We should really fix this together, it's painful. Mozilla will create WPT anyway for our own coverage and hopefully for others in the future.)

> Moreover, WPT support for changing permissions is kind of limited at the moment.

Both Gecko and Blink support `test_driver.set_permission()` so this is not really true. (WebKit indeed doesn't support this, but having some test is better than having nothing)

> @@ -342,6 +342,16 @@ <h2>
           `{name: "push", userVisibleOnly: false}` is [=PermissionDescriptor/stronger than=]
           `{name: "push", userVisibleOnly: true}`.
         </p>
+        <p>
+          When the permission state changes (for example, it is revoked or re-granted), the <a>user

This should probably use the revocation hook: https://w3c.github.io/permissions/#dfn-permission-revocation-algorithm

Would be nice if we can decide whether this should be on revocation, regranted, or both.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/400#pullrequestreview-2783699621
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/400/review/2783699621@github.com>