Re: [w3c/selection-api] Change getComposedRanges to have options as input (PR #331)

@annevk commented on this pull request.



> @@ -405,7 +409,7 @@ <h2>
             <li>Otherwise, let <var>startNode</var> be [=range/start node=] of the [=range=] associated with [=this=],
               and let <var>startOffset</var> be [=range/start offset=] of the [=range=].</li>
             <li>While <var>startNode</var> is a [=node=], <var>startNode</var>'s [=tree/root=] is a [=shadow root=],
-              and <var>startNode</var>'s [=tree/root=] is not a [=shadow-including inclusive ancestor=] of any of <var>shadowRoots</var>,
+              and <var>startNode</var>'s [=tree/root=] is not a [=shadow-including inclusive ancestor=] of any of <var>options.shadowRoots</var>,

This (and below) needs different syntax. You want it look something like this:

> _options_["`shadowRoots`"]

Ideally with `shadowRoots` linking back to its IDL definition.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/selection-api/pull/331#pullrequestreview-2334423435
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/selection-api/pull/331/review/2334423435@github.com>