Re: [whatwg/fetch] Clarify that request.origin cannot be "client" at certain points (PR #1776)

@annevk commented on this pull request.



> @@ -2230,6 +2230,8 @@ or "<code>object</code>".
 return true:
 
 <ol>
+ <li> Assert: <var>request</var>'s <a for=request>origin</a> is not "<code>client</code>".

```suggestion
 <li><p><a for=/>Assert</a>: <var>request</var>'s <a for=request>origin</a> is not
 "<code>client</code>".
```

> @@ -2230,6 +2230,8 @@ or "<code>object</code>".
 return true:
 
 <ol>
+ <li> Assert: <var>request</var>'s <a for=request>origin</a> is not "<code>client</code>".

In particular, no space after `<li>` but it also needs a nested `<p>` like the other `<li>`s, we want to link Assert as people can use the additional guidance that provides, and then we need to wrap at a 100 columns unfortunately due to the additional text.

If you apply this throughout I'd be happy to merge this. Thanks for turning it around so quickly!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1776#pullrequestreview-2328144820
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1776/review/2328144820@github.com>

Received on Wednesday, 25 September 2024 12:46:35 UTC