Re: [w3c/gamepad] Add sequenceId slot and fix effect promises (PR #201)

@gterzian commented on this pull request.



>                    <ol>
-                    <li>If |effectPromise| and
-                    [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}}
-                    are still the same, set
-                    [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}}
-                    to `null`.
-                    </li>
-                    <li>[=Queue a global task=] on the [=relevant global
-                    object=] of [=this=] using the [=gamepad task source=] to
-                    [=resolve=] |effectPromise| with
-                    {{GamepadHapticsResult/"preempted"}}.
+                    <li>If [=this=].{{GamepadHapticActuator/[[sequenceId]]}} is
+                    |resetSequenceId|:

On second thought, not sure if an early return makes sense, given we always still need to return the promise at the end(we'd end up with two return statements). 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/201#discussion_r1608816253
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/201/review/2069405991@github.com>