- From: smaug---- <notifications@github.com>
- Date: Wed, 08 May 2024 11:23:19 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1261/review/2046358659@github.com>
@smaug---- commented on this pull request. > + modify the tree's structure, making live traversal unsafe, possibly leading to the + <a>post-insertion steps</a> being called multiple times on the same <a>node</a>.</p> + </li> + + <li> + <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>: + + <ol> + <li><p>For each <a>shadow-including inclusive descendant</a> <var>inclusiveDescendant</var> of + <var>node</var>, in <a>shadow-including tree order</a>, <a for=list>append</a> + <var>inclusiveDescendant</var> to <var>staticNodeList</var>. + </ol> + </li> + + <li><p><a for=list>For each</a> <var>node</var> in <var>staticNodeList</var>, if <var>node</var> is + <a>connected</a>, then run the <a>post-insertion steps</a> with <var>node</var>. (just wondering what should happen, and what browsers do if some earlier post-connected step moves a node, which hasn't get change to run post-connected steps to be elsewhere in the document - so its post-connected steps get run twice. That might be a case to handle separately in each case - but if that is needed, it might be easy to just add is-connected check to the element specific algorithm) -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1261#pullrequestreview-2046358659 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1261/review/2046358659@github.com>
Received on Wednesday, 8 May 2024 18:23:24 UTC