- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 25 Jan 2024 06:53:21 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 25 January 2024 14:53:28 UTC
@annevk commented on this pull request. > + <ol> + <li><p>Set <var>attribute</var> to a new <a>attribute</a> whose <a for=Attr>namespace</a> is + <var>namespace</var>, <a for=Attr>namespace prefix</a> is <var>prefix</var>, + <a for=Attr>local name</a> is <var>localName</var> and <a for=Node>node document</a> is + <var>element</var>'s <a for=Node>node document</a>. + + <li><p><a>Validate and set attribute value</a> <var>value</var> for <var>attribute</var> with + <var>element</var>. + + <li><p><a lt="append an attribute">Append</a> <var>attribute</var> to <var>element</var>. + + <li><p>Return. + </ol> In particular because in these cases we end up creating a new attribute and so if something throws, it would simply be as if that attribute was not created, right? And it seems that the current algorithms miss the `toggleAttribute()` endpoint. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1247#discussion_r1466492638 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1247/review/1843932004@github.com>
Received on Thursday, 25 January 2024 14:53:28 UTC