- From: Krzysztof Kotowicz <notifications@github.com>
- Date: Tue, 23 Jan 2024 08:50:30 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1247@github.com>
This calls the get Trusted Types-compliant attribute value algorithm from Trusted Types (https://github.com/w3c/trusted-types/pull/418) from attribute's change, append, and replace. Changed the signature of `setAttribute` and `setAttributeNS` to accept Trusted Types as values. The underlying Attr node's values continue to be `DOMString`, so moving nodes across elements or adding standalone attributes to elements can cause TT violations. This matches WPT tests and the Chromium's implementation. See and #789. Supercedes PR #809. <!-- Thank you for contributing to the DOM Standard! Please describe the change you are making and complete the checklist below if your change is not editorial. When editing this comment after the PR is created, check that PR-Preview doesn't overwrite your changes. If you think your PR is ready to land, please double-check that the build is passing and the checklist is complete before pinging. --> - [x] At least two implementers are interested (and none opposed): * Gecko * Chromium (already implemented) - [x] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * https://github.com/web-platform-tests/wpt/tree/master/trusted-types - [x] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=739170 * Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1508286 - [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: … - [x] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. --> (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.) You can view, comment on, or merge this pull request online at: https://github.com/whatwg/dom/pull/1247 -- Commit Summary -- * Draft integration with Trusted Types, take 2. -- File Changes -- M dom.bs (27) -- Patch Links -- https://github.com/whatwg/dom/pull/1247.patch https://github.com/whatwg/dom/pull/1247.diff -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1247 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1247@github.com>
Received on Tuesday, 23 January 2024 16:50:38 UTC