Re: [whatwg/fetch] Editorial: Move handling of request 'client' to its own steps (PR #1793)

@annevk commented on this pull request.

Looks good modulo some minor nits.

> @@ -4459,6 +4438,34 @@ the response. [[!HTTP-CACHING]]
 </ol>
 </div>
 
+<div algorithm>
+<p>To <dfn>populate request from client</dfn> given a <a for=/>request</a> <var>request</var>:
+<ol>

Newline before `<ol>`

> + <li><p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>", then set
+ <var>request</var>'s <a for=request>window</a> to <var>request</var>'s <a for=request>client</a>,
+ if <var>request</var>'s <a for=request>client</a>'s
+ <a for="environment settings object">global object</a> is a {{Window}} object; otherwise
+ "<code>no-window</code>".

```suggestion
 <li><p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>", then: set
 <var>request</var>'s <a for=request>window</a> to <var>request</var>'s <a for=request>client</a>
 if <var>request</var>'s <a for=request>client</a>'s
 <a for="environment settings object">global object</a> is a {{Window}} object; otherwise
 "<code>no-window</code>".
```

> @@ -4459,6 +4438,34 @@ the response. [[!HTTP-CACHING]]
 </ol>
 </div>
 
+<div algorithm>
+<p>To <dfn>populate request from client</dfn> given a <a for=/>request</a> <var>request</var>:
+<ol>
+ <li><p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>", then set
+ <var>request</var>'s <a for=request>window</a> to <var>request</var>'s <a for=request>client</a>,
+ if <var>request</var>'s <a for=request>client</a>'s
+ <a for="environment settings object">global object</a> is a {{Window}} object; otherwise
+ "<code>no-window</code>".
+
+ <li><p>If <var>request</var>'s <a for=request>origin</a> is "<code>client</code>", then set
+ <var>request</var>'s <a for=request>origin</a> to  <var>request</var>'s <a for=request>client</a>'s
+ <a for="environment settings object">origin</a>.
+
+ <li>
+  <p>If <var>request</var>'s <a for=request>policy container</a> is "<code>client</code>", then:

```suggestion
  <p>If <var>request</var>'s <a for=request>policy container</a> is "<code>client</code>":
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1793#pullrequestreview-2501803057
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1793/review/2501803057@github.com>