- From: Dominic Farolino <notifications@github.com>
- Date: Thu, 12 Dec 2024 07:29:23 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1331/review/2500005177@github.com>
@domfarolino approved this pull request. I guess this PR should accompany one that updates the relevant HTML reference too: https://html.spec.whatwg.org/C#creating-and-inserting-nodes:create-an-element? > @@ -6306,16 +6303,12 @@ value of these steps: <p class=note>User agents could optimize <a for=Element>qualified name</a> and <a for=Element>HTML-uppercased qualified name</a> by storing them in internal slots. -<p>To -<dfn export id=concept-create-element lt="create an element|creating an element">create an element</dfn>, -given a <var>document</var>, <var>localName</var>, <var>namespace</var>, and optional -<var>prefix</var>, <var>is</var>, and <var>synchronous custom elements flag</var>, run these steps: +<p>To <dfn export id=concept-create-element>create an element</dfn>, given a <a for=/>document</a> Why this instead of just `<a>document</a>`, as you did in https://github.com/whatwg/dom/pull/1307#discussion_r1881966012? > @@ -6341,8 +6334,8 @@ given a <var>document</var>, <var>localName</var>, <var>namespace</var>, and opt <var>document</var>. <li> - <p>If the <var>synchronous custom elements flag</var> is set, then run this step while - catching any exceptions: + <p>If <var>synchronousCustomElements</var> is true, then run this step while catching any + exceptions: Maybe not for this PR, but I guess we should not say anything here about exceptions, and just link to https://webidl.spec.whatwg.org/#an-exception-was-thrown somewhere in "If this step threw an exception" below. Doesn't need to happen in this PR I guess. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1331#pullrequestreview-2500005177 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1331/review/2500005177@github.com>
Received on Thursday, 12 December 2024 15:29:27 UTC