Re: [whatwg/dom] Introduce `moveBefore()` state-preserving atomic move API (PR #1307)

> I think you now allow elements to be moved into document's children without any kind of additional checks.

OK, I've fixed this, adding the relevant pre-insertion conditions to the pre-move algorithm. I'll do the same for Chromium and WPTs.

> The checks are also in a different order.

Fixed. The pre-move-specific checks still come first, but all **relevant** pre-insert conditions come after, and in the same order as the appear in the pre-insertion algorithm.

> And given how many are shared it probably warrants more abstraction.

Hmm, I could go either way. There are not that many conditions in pre-move that are carbon copies of their corresponding conditions pre-insert conditions. Perhaps the first 3 can be cleanly lifted out now, but the remaining are modified enough to probably not warrant abstraction. Would you prefer I lift the first 3 conditions out into a common sub algorithm?

> (Also, "pre-insertion", but "pre-move" is weird. Maybe "pre-insertion" is wrong?)

I've renamed all "pre-insertion" instances to "pre-insert".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1307#issuecomment-2532831684
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1307/c2532831684@github.com>