- From: Dominic Farolino <notifications@github.com>
- Date: Tue, 10 Dec 2024 07:40:23 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 10 December 2024 15:40:27 UTC
@domfarolino commented on this pull request. > + <li><p>If <var>parent</var> is not an {{Element}} or {{DocumentFragment}} <a for=/>node</a>, then + <a>throw</a> a "{{HierarchyRequestError!!exception}}" {{DOMException}}. OK I've done that in https://github.com/whatwg/dom/pull/1307/commits/90c9a943a859267acd05b37c48120427e497c7e2, and changed the Chromium implementation and added a test in https://crrev.com/c/6081493. I agree this is a pretty minor change, especially since Documents can still only have a single Element child, and it is nice to have consistency with the pre-insertion validity conditions. I'll resolve this now. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1307#discussion_r1878335783 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1307/review/2492740120@github.com>
Received on Tuesday, 10 December 2024 15:40:27 UTC