- From: Dominic Farolino <notifications@github.com>
- Date: Mon, 09 Dec 2024 12:36:26 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 9 December 2024 20:36:30 UTC
@domfarolino commented on this pull request.
> + <li><p>If <var>parent</var> is not an {{Element}} or {{DocumentFragment}} <a for=/>node</a>, then
+ <a>throw</a> a "{{HierarchyRequestError!!exception}}" {{DOMException}}.
Hmm, OK. Would you prefer we simply make this condition perfectly match the pre-insertion validity steps? I.e., expanding it to include Document parents too? I'm fine with that. Let me know what you think @annevk.
> Yeah, I'd expect this to handle basically ParentNode mixin.
Hmm, I'm not exactly sure what this means. But does what I recommend above satisfy what you're looking for?
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1307#discussion_r1876720559
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/dom/pull/1307/review/2490023899@github.com>
Received on Monday, 9 December 2024 20:36:30 UTC