- From: Shannon Booth <notifications@github.com>
- Date: Fri, 06 Dec 2024 19:36:49 -0800
- To: w3c/FileAPI <FileAPI@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/FileAPI/pull/205@github.com>
Otherwise reading the stream will never end up finishing when it is read, even once all chunks are finished.
I think this is what all engines would already do (e.g WebKit: https://github.com/WebKit/WebKit/blob/fcb00789e9e97821473027e844e7bf12a32b8a99/Source/WebCore/fileapi/Blob.cpp#L351).
WPT tests already rely on this being done from what I understand.
Closes #???
For *normative* changes, the following tasks have been completed:
* [ ] Modified Web platform tests (link to pull request)
Implementation commitment:
* [ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=)
* [ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=)
* [ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/shannonbooth/FileAPI/pull/205.html" title="Last updated on Dec 7, 2024, 3:36 AM UTC (6218658)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/FileAPI/205/77b2086...shannonbooth:6218658.html" title="Last updated on Dec 7, 2024, 3:36 AM UTC (6218658)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/FileAPI/pull/205
-- Commit Summary --
* Add missing close call to blob-get-stream
-- File Changes --
M index.bs (1)
-- Patch Links --
https://github.com/w3c/FileAPI/pull/205.patch
https://github.com/w3c/FileAPI/pull/205.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/FileAPI/pull/205
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/FileAPI/pull/205@github.com>
Received on Saturday, 7 December 2024 03:36:53 UTC