- From: Andrew Williams <notifications@github.com>
- Date: Fri, 06 Dec 2024 15:12:19 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1783/review/2486106134@github.com>
@recvfrom commented on this pull request.
>
<p class=note>The `<code>GET</code>` <a for=/>method</a> restriction serves no useful purpose
other than being interoperable.
- <li><p>Let <var>blob</var> be <var>blobURLEntry</var>'s <a for="blob URL entry">object</a>.
+ <li><p>Let <var>requestEnvironment</var> be the result of
+ <a for=request>determining the environment</a> given <var>request</var>.
+
+ <li><p>Let <var>isTopLevelNavigation</var> be true if <var>request</var>'s <a
+ for=request>destination</a> is "<code>document</code>"; otherwise, false.
+
+ <li><p>If <var>isTopLevelNavigation</var> is false and <var>requestEnvironment</var> is null,
+ then return a <a>network error</a>.
+
+ <li><p>Let <var>blob</var> be null.
+
+ <li><p>If <var>isTopLevelNavigation</var> is true, then set <var>blob</var> to the result of
+ <a href="https://w3c.github.io/FileAPI/#blob-url-obtain-object">obtaining a blob object</a>
+ given <var>blobURLEntry</var> and the string "<code>navigation</code>".
Thanks for the feedback, I wasn't sure if it was OK to assign values of different types into a variable. It's indeed simpler with only the one call to "obtaining a blob object". Thanks, and done!
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1783#discussion_r1874109424
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/fetch/pull/1783/review/2486106134@github.com>
Received on Friday, 6 December 2024 23:12:23 UTC