Re: [whatwg/fetch] Deferred fetching feedback (Issue #1715)

Some more comments:

- The PR template is not kept up-to-date nor completed.
- The formatting for many string values seems wrong. We format strings "`thus`". The quotation marks are notably not in code.
- A lot of exceptions in `fetchLater()` for rather fundamental checks are thrown late because they are in "request a deferred fetch". They should probably be moved in to `fetchLater()` and up.
- The use of `DOMException` feels out of place. `fetch()` currently does not use that except for `AbortSignal` and I'd rather keep this the same.
- Where you have ["activateAfter"] it's not linked.
- I don't think "total request length" should throw. The caller should complain when it's null.
- I don't understand why "total request length" has seemingly redundant checks for the null case.
- "For each" should always use "of", not "in".
- Document is not linked.
- Disabled should probably be a string and consistently cased as well. We don't really do unique-ish values.
- Some examples would help, especially around corner cases, but maybe also how we'd expect people to use this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/issues/1715#issuecomment-2523537396
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/issues/1715/2523537396@github.com>

Received on Friday, 6 December 2024 15:48:29 UTC